Repository navigation
[3.15] gh-157468: Validate correct builtins used under JIT (GH-157766) - #159048
Merged
Merged
Conversation
…honGH-157766) * Expose two possible builtin JIT gaps * Add trace and runtime guard for builtin dict * Check _GUARD_BUILTINS_IS_CANONICAL once per frame * Add check and fix for globals being folded (cherry picked from commit 0906d2a) Co-authored-by: John <me@joh.ng>
johng
requested review from
Fidget-Spinner,
markshannon,
methane,
savannahostrowski and
tomasr8
as code owners
October 9, 2026 06:53
Contributor
Author
|
@markshannon could you review please as a followup to the linked PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose two possible builtin JIT gaps
Add trace and runtime guard for builtin dict
Check _GUARD_BUILTINS_IS_CANONICAL once per frame
Add check and fix for globals being folded
(cherry picked from commit 0906d2a)
Co-authored-by: John me@joh.ng
Manual backport: the only conflict was in the generated
Include/internal/pycore_uop_ids.h; resolved by runningmake regen-caseson 3.15.